-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on PHP 8.3 and update test suite #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
force-pushed
the
test_suite
branch
from
November 9, 2023 14:57
aa95774
to
a0002bb
Compare
SimonFrings
changed the title
Run tests on PHP 8.2 and PHP 8.3 and update test suite
Run tests on PHP 8.3 and update test suite
Nov 9, 2023
SimonFrings
added
new feature
New feature or request
maintenance
and removed
maintenance
labels
Nov 9, 2023
clue
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonFrings Thanks for the update, changes LGTM!
This was referenced Nov 13, 2023
This was referenced Nov 24, 2023
This was referenced Jan 17, 2024
Merged
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #19 and #28.
References: reactphp/socket#300, clue/reactphp-zenity#63 and others.
After this pull request is merged, we can continue with #32.